From: Dylan William Hardison <dylan@hardison.net>
Date: Mon, 12 Mar 2018 20:44:16 +0000 (-0400)
Subject: no bug - increase severity of several critic warnings so they're more visibile
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b6ffa8dec3bd7b14f8096a60ad9740ccda92a044;p=thirdparty%2Fbugzilla.git

no bug - increase severity of several critic warnings so they're more visibile
---

diff --git a/.perlcriticrc b/.perlcriticrc
index 15ff6c82b..0c0d1c9be 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -3,10 +3,28 @@ severity = 1
 
 [-CodeLayout::RequireTidyCode]
 #perltidyrc = .perltidyrc
+#severity = 2
+
 [InputOutput::RequireCheckedSyscalls]
+severity = 2
 functions = :builtins
 exclude_functions = print say sleep binmode
 
+[ValuesAndExpressions::ProhibitInterpolationOfLiterals]
+severity = 2
+
+[Freenode::EmptyReturn]
+severity = 2
+
+[CodeLayout::RequireTrailingCommas]
+severity = 2
+
+[CodeLayout::ProhibitParensWithBuiltins]
+severity = 2
+
+[RegularExpressions::ProhibitUnusualDelimiters]
+severity = 2
+
 [-BuiltinFunctions::ProhibitUselessTopic]
 [-ControlStructures::ProhibitCascadingIfElse]
 [-ControlStructures::ProhibitPostfixControls]
@@ -46,7 +64,7 @@ exclude_functions = print say sleep binmode
 
 # _build_* are allowed
 [Subroutines::ProhibitUnusedPrivateSubroutines]
- private_name_regex = _(?!_|build_)\w+
+private_name_regex = _(?!_|build_)\w+
 
 # I don't agree with this policy because
 # a bare return can actually cause more problems.