From: Nicholas Vinson Date: Wed, 25 Feb 2026 00:48:40 +0000 (-0500) Subject: osdep/linux/ofpath: Correct path_size calculation X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b71ae6db282fa25ca4ea6f8169161a2131ee6b9a;p=thirdparty%2Fgrub.git osdep/linux/ofpath: Correct path_size calculation path_size is computed in part by taking the size of the format string. However, the format string contains conversion specifiers. These conversion specifiers are included in the size calculation resulting in a size calculation that is larger than it needs to be. This patch corrects that error by removing the conversion specifiers when computing path_size. Signed-off-by: Nicholas Vinson Reviewed-by: Daniel Kiper --- diff --git a/grub-core/osdep/linux/ofpath.c b/grub-core/osdep/linux/ofpath.c index 0ebfea44c..38d9bb5bf 100644 --- a/grub-core/osdep/linux/ofpath.c +++ b/grub-core/osdep/linux/ofpath.c @@ -507,7 +507,7 @@ check_sas (const char *sysfs_path, int *tgt, unsigned long int *sas_address) p_len = (int) (q - sysfs_path); ed_len = (int) (q - ed); - path_size = (p_len + ed_len + sizeof ("%s/sas_device/%s/phy_identifier")); + path_size = (p_len + ed_len + sizeof ("/sas_device//phy_identifier")); path = xmalloc (path_size); snprintf (path, path_size, "%.*s/sas_device/%.*s/phy_identifier", p_len, sysfs_path, ed_len, ed);