From: Benjamin Herrenschmidt Date: Fri, 23 Dec 2022 01:48:47 +0000 (+1100) Subject: term/serial: Replace usage of memcmp() with strncmp() X-Git-Tag: grub-2.12-rc1~168 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b73a44b281908526048fd5884cde463a0a275280;p=thirdparty%2Fgrub.git term/serial: Replace usage of memcmp() with strncmp() We are comparing strings after all. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Daniel Kiper --- diff --git a/grub-core/term/serial.c b/grub-core/term/serial.c index 595e74b16..6e9483cb8 100644 --- a/grub-core/term/serial.c +++ b/grub-core/term/serial.c @@ -152,7 +152,7 @@ grub_serial_find (const char *name) break; #if (defined(__mips__) || defined (__i386__) || defined (__x86_64__)) && !defined(GRUB_MACHINE_EMU) && !defined(GRUB_MACHINE_ARC) - if (!port && grub_memcmp (name, "port", sizeof ("port") - 1) == 0 + if (!port && grub_strncmp (name, "port", sizeof ("port") - 1) == 0 && grub_isxdigit (name [sizeof ("port") - 1])) { name = grub_serial_ns8250_add_port (grub_strtoul (&name[sizeof ("port") - 1], @@ -245,7 +245,7 @@ grub_serial_find (const char *name) #endif #ifdef GRUB_MACHINE_IEEE1275 - if (!port && grub_memcmp (name, "ieee1275/", sizeof ("ieee1275/") - 1) == 0) + if (!port && grub_strncmp (name, "ieee1275/", sizeof ("ieee1275/") - 1) == 0) { name = grub_ofserial_add_port (&name[sizeof ("ieee1275/") - 1]); if (!name)