From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Tue, 31 Oct 2023 16:08:28 +0000 (+0100)
Subject: auth: mech-oauth2 - Don't send payload for internal error
X-Git-Tag: 2.4.2~448
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b74c790b76b0adfdc1bd34960136ecf29ff8bef0;p=thirdparty%2Fdovecot%2Fcore.git

auth: mech-oauth2 - Don't send payload for internal error
---

diff --git a/src/auth/mech-oauth2.c b/src/auth/mech-oauth2.c
index 31778e445d..ec48f72ea8 100644
--- a/src/auth/mech-oauth2.c
+++ b/src/auth/mech-oauth2.c
@@ -83,8 +83,7 @@ oauth2_verify_callback(enum passdb_result result,
 
 	switch (result) {
 	case PASSDB_RESULT_INTERNAL_FAILURE:
-		/* Non-standard response */
-		oauth2_fail(oauth2_req, 500, "internal_failure");
+		auth_request_internal_failure(request);
 		break;
 	case PASSDB_RESULT_USER_DISABLED:
 	case PASSDB_RESULT_PASS_EXPIRED:
@@ -227,7 +226,7 @@ mech_oauthbearer_auth_continue(struct auth_request *request,
 
 	if (oauth2_req->db == NULL) {
 		e_error(request->event, "BUG: oauth2 database missing");
-		oauth2_fail(oauth2_req, 500, "internal_failure");
+		auth_request_internal_failure(request);
 		return;
 	}
 	if (data_size == 0) {
@@ -331,7 +330,7 @@ mech_xoauth2_auth_continue(struct auth_request *request,
 
 	if (oauth2_req->db == NULL) {
 		e_error(request->event, "BUG: oauth2 database missing");
-		oauth2_fail(oauth2_req, 500, "internal_failure");
+		auth_request_internal_failure(request);
 		return;
 	}
 	if (data_size == 0) {