From: Eric Wong <e@80x24.org>
Date: Thu, 9 Nov 2023 10:09:39 +0000 (+0000)
Subject: lei ls-mail-source: gracefully handle network failures
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b7c01eafca786e1a36b75cb8ec682a6d008a0a36;p=thirdparty%2Fpublic-inbox.git

lei ls-mail-source: gracefully handle network failures

All network connections may fail, so try to emit a helpful
error message instead of attempting to dispatch methods off
`undef'.
---

diff --git a/lib/PublicInbox/LeiLsMailSource.pm b/lib/PublicInbox/LeiLsMailSource.pm
index 50799270a..4b427b268 100644
--- a/lib/PublicInbox/LeiLsMailSource.pm
+++ b/lib/PublicInbox/LeiLsMailSource.pm
@@ -19,7 +19,8 @@ sub input_path_url { # overrides LeiInput version
 	if ($url =~ m!\Aimaps?://!i) {
 		my $uri = PublicInbox::URIimap->new($url);
 		my $sec = $lei->{net}->can('uri_section')->($uri);
-		my $mic = $lei->{net}->mic_get($uri);
+		my $mic = $lei->{net}->mic_get($uri) or
+			return $lei->err("E: $uri");
 		my $l = $mic->folders_hash($uri->path); # server-side filter
 		@$l = map { $_->[2] } # undo Schwartzian transform below:
 			sort { $a->[0] cmp $b->[0] || $a->[1] <=> $b->[1] }
@@ -39,7 +40,8 @@ sub input_path_url { # overrides LeiInput version
 		}
 	} elsif ($url =~ m!\A(?:nntps?|s?news)://!i) {
 		my $uri = PublicInbox::URInntps->new($url);
-		my $nn = $lei->{net}->nn_get($uri);
+		my $nn = $lei->{net}->nn_get($uri) or
+			return $lei->err("E: $uri");
 		my $l = $nn->newsgroups($uri->group); # name => description
 		my $sec = $lei->{net}->can('uri_section')->($uri);
 		if ($json) {