From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 24 Sep 2008 01:59:53 +0000 (+0200)
Subject: s4:libcli/smb_composite: we only check the signature when the server return OK
X-Git-Tag: samba-4.0.0alpha6~769^2~238^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b7d2ff38f54250db52c495d26a2b2923e5dcc83e;p=thirdparty%2Fsamba.git

s4:libcli/smb_composite: we only check the signature when the server return OK

We need to manually free the request, otherwise the timeout handler is
triggered later.

metze
---

diff --git a/source4/libcli/smb_composite/sesssetup.c b/source4/libcli/smb_composite/sesssetup.c
index 92b49dc3d40..645f5362ac3 100644
--- a/source4/libcli/smb_composite/sesssetup.c
+++ b/source4/libcli/smb_composite/sesssetup.c
@@ -97,6 +97,15 @@ static void request_handler(struct smbcli_request *req)
 	c->status = state->remote_status;
 	state->req = NULL;
 
+	/*
+	 * we only need to check the signature if the
+	 * NT_STATUS_OK is returned
+	 */
+	if (!NT_STATUS_IS_OK(state->remote_status)) {
+		talloc_free(check_req);
+		check_req = NULL;
+	}
+
 	switch (state->setup.old.level) {
 	case RAW_SESSSETUP_OLD:
 		state->io->out.vuid = state->setup.old.out.vuid;