From: Victor Julien <victor@inliniac.net>
Date: Mon, 13 Apr 2020 13:47:18 +0000 (+0200)
Subject: datasets: improve 'dataset-add' error checking
X-Git-Tag: suricata-6.0.0-beta1~496
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b80ab56d10d9907e3dcab8cdcd2285c711201de8;p=thirdparty%2Fsuricata.git

datasets: improve 'dataset-add' error checking
---

diff --git a/src/runmode-unix-socket.c b/src/runmode-unix-socket.c
index 07c0d52254..355d1305f4 100644
--- a/src/runmode-unix-socket.c
+++ b/src/runmode-unix-socket.c
@@ -667,6 +667,10 @@ TmEcode UnixSocketDatasetAdd(json_t *cmd, json_t* answer, void *data)
     SCLogDebug("dataset-add: %s type %s value %s", set_name, type, value);
 
     enum DatasetTypes t = DatasetGetTypeFromString(type);
+    if (t == DATASET_TYPE_NOTSET) {
+        json_object_set_new(answer, "message", json_string("unknown settype"));
+        return TM_ECODE_FAILED;
+    }
 
     Dataset *set = DatasetFind(set_name, t);
     if (set == NULL) {