From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 17 Sep 2021 04:43:00 +0000 (+1200)
Subject: autobuild: allow AUTOBUILD_FAIL_IMMEDIATELY=0 (say from a gitlab variable)
X-Git-Tag: ldb-2.5.0~597
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b81f6f3d71487085bb355392ce7f8eff2db5bb4d;p=thirdparty%2Fsamba.git

autobuild: allow AUTOBUILD_FAIL_IMMEDIATELY=0 (say from a gitlab variable)

This allows making a push to do a full test ignoring errors without
needing "HACK!!!" commits on top.

Use like this:

git push -o ci.variable='AUTOBUILD_FAIL_IMMEDIATELY=0'

RN: Samba CI runs can now continue past the first error if AUTOBUILD_FAIL_IMMEDIATELY=0 is set

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14841

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/script/autobuild.py b/script/autobuild.py
index e42e2365488..f521a2e7d2e 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -166,7 +166,6 @@ def format_option(name, value=None):
 
 def make_test(
         cmd='make testonly',
-        FAIL_IMMEDIATELY=1,
         INJECT_SELFTEST_PREFIX=1,
         TESTS='',
         include_envs=None,
@@ -182,7 +181,13 @@ def make_test(
         TESTS = (TESTS + ' ' + ' '.join(test_options)).strip()
 
     _options = []
-    if FAIL_IMMEDIATELY:
+
+    # Allow getting a full CI with
+    # git push -o ci.variable='AUTOBUILD_FAIL_IMMEDIATELY=0'
+
+    FAIL_IMMEDIATELY = os.getenv("AUTOBUILD_FAIL_IMMEDIATELY", "1")
+
+    if int(FAIL_IMMEDIATELY):
         _options.append('FAIL_IMMEDIATELY=1')
     if TESTS:
         _options.append("TESTS='{}'".format(TESTS))