From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 1 Nov 2017 19:44:54 +0000 (+0200)
Subject: login-common: client_unref() - always set client pointer to NULL
X-Git-Tag: 2.3.0.rc1~595
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b833824981bc75af72adb844f8a4a992bd2f3ad3;p=thirdparty%2Fdovecot%2Fcore.git

login-common: client_unref() - always set client pointer to NULL

This is the common coding practise elsewhere as well.
---

diff --git a/src/login-common/client-common.c b/src/login-common/client-common.c
index 9d9c230c12..7d3a85246b 100644
--- a/src/login-common/client-common.c
+++ b/src/login-common/client-common.c
@@ -326,12 +326,12 @@ bool client_unref(struct client **_client)
 {
 	struct client *client = *_client;
 
+	*_client = NULL;
+
 	i_assert(client->refcount > 0);
 	if (--client->refcount > 0)
 		return TRUE;
 
-	*_client = NULL;
-
 	i_assert(client->destroyed);
 	i_assert(client->login_proxy == NULL);