From: Christophe JAILLET Date: Sat, 13 May 2017 11:40:20 +0000 (+0200) Subject: ARM: davinci: PM: Do not free useful resources in normal path in 'davinci_pm_init' X-Git-Tag: v4.11.9~22 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b856d45c710620d4324b660be1f36ce561ebc281;p=thirdparty%2Fkernel%2Fstable.git ARM: davinci: PM: Do not free useful resources in normal path in 'davinci_pm_init' commit 95d7c1f18bf8ac03b0fc48eac1f1b11f867765b8 upstream. It is wrong to iounmap resources in the normal path of davinci_pm_init() The 3 ioremap'ed fields of 'pm_config' can be accessed later on in other functions, so we should return 'success' instead of unrolling everything. Fixes: aa9aa1ec2df6 ("ARM: davinci: PM: rework init, remove platform device") Signed-off-by: Christophe JAILLET [nsekhar@ti.com: commit message and minor style fixes] Signed-off-by: Sekhar Nori Signed-off-by: Greg Kroah-Hartman --- diff --git a/arch/arm/mach-davinci/pm.c b/arch/arm/mach-davinci/pm.c index 316b353054c90..28255af5f2d8f 100644 --- a/arch/arm/mach-davinci/pm.c +++ b/arch/arm/mach-davinci/pm.c @@ -163,6 +163,8 @@ int __init davinci_pm_init(void) suspend_set_ops(&davinci_pm_ops); + return 0; + no_sram_mem: iounmap(pm_config.ddrpsc_reg_base); no_ddrpsc_mem: