From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 17 Jul 2023 13:24:43 +0000 (+0200)
Subject: virrandom: Fix printf format string in virRandomGenerateWWN()
X-Git-Tag: v9.6.0-rc1~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b857ad0696ca5177eccf482f244665c246b3ace8;p=thirdparty%2Flibvirt.git

virrandom: Fix printf format string in virRandomGenerateWWN()

Firstly, drop needless concatenation of two static strings.
Secondly, use proper (portable) formatter for uint64_t so that
typecast to ULL can be dropped.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/util/virrandom.c b/src/util/virrandom.c
index 73c5832a05..58f86d5a00 100644
--- a/src/util/virrandom.c
+++ b/src/util/virrandom.c
@@ -154,8 +154,7 @@ virRandomGenerateWWN(char **wwn,
         return -1;
     }
 
-    *wwn = g_strdup_printf("5" "%s%09llx", oui,
-                           (unsigned long long)virRandomBits(36));
+    *wwn = g_strdup_printf("5%s%09" PRIx64, oui, virRandomBits(36));
     return 0;
 }