From: Ruediger Pluem <rpluem@apache.org>
Date: Wed, 4 Jun 2025 07:37:32 +0000 (+0000)
Subject: Merge r1923806 from trunk:
X-Git-Tag: 2.4.64-rc1-candidate~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b861e717cdb5775b7cf277b2bdda92101f95859f;p=thirdparty%2Fapache%2Fhttpd.git

Merge r1923806 from trunk:

Fix variable declaration warning in scoreboard.c

Submitted by: Vladimír Chlup <vchlup redhat.com>
Github: closes #516

Reviewed by: rpluem, jorton, ylavic


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1926108 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index 7288e1499b..a598de5003 100644
--- a/STATUS
+++ b/STATUS
@@ -205,14 +205,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
                  undefined otherwise.
      rpluem says: Good catch. Added r1926091 and reset votes.
 
-  *) scoreboard.c: Fix variable declaration warning in scoreboard.c
-     Trunk version of patch:
-        https://svn.apache.org/r1923806
-     Backport version for 2.4.x of patch:
-      Trunk version of patch works
-      svn merge -c 1923806 ^/httpd/httpd/trunk .
-     +1: rpluem, jorton, ylavic
-
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 
diff --git a/server/scoreboard.c b/server/scoreboard.c
index ec18281b21..adc97d8fff 100644
--- a/server/scoreboard.c
+++ b/server/scoreboard.c
@@ -656,11 +656,11 @@ AP_DECLARE(void) ap_time_process_request(ap_sb_handle_t *sbh, int status)
 AP_DECLARE(void) ap_set_time_process_request(ap_sb_handle_t* const sbh,
 		const apr_time_t timebeg,const apr_time_t timeend)
 {
+    worker_score *ws;
     if (!sbh || sbh->child_num < 0)
         return;
 
-    worker_score* const ws =
-	&ap_scoreboard_image->servers[sbh->child_num][sbh->thread_num];
+    ws = &ap_scoreboard_image->servers[sbh->child_num][sbh->thread_num];
     
     ws->start_time = timebeg;
     ws->stop_time = ws->last_used = timeend;