From: Joerg Behrmann Date: Fri, 7 Jul 2023 07:54:50 +0000 (+0200) Subject: tests: add tests to exercise GenericVersion X-Git-Tag: v15~82^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b874674e64c55b8461fd19fe54fc2bcdd1a60f6d;p=thirdparty%2Fmkosi.git tests: add tests to exercise GenericVersion --- diff --git a/tests/test_config.py b/tests/test_config.py new file mode 100644 index 000000000..abdcbf515 --- /dev/null +++ b/tests/test_config.py @@ -0,0 +1,223 @@ +# SPDX-License-Identifier: LGPL-2.1+ + +import itertools + +import pytest + +from mkosi.config import GenericVersion + + +def test_generic_version_systemd() -> None: + """Same as the first block of systemd/test/test-compare-versions.sh""" + assert GenericVersion("1") < GenericVersion("2") + assert GenericVersion("1") <= GenericVersion("2") + assert GenericVersion("1") != GenericVersion("2") + assert not (GenericVersion("1") > GenericVersion("2")) + assert not (GenericVersion("1") == GenericVersion("2")) + assert not (GenericVersion("1") >= GenericVersion("2")) + + +def test_generic_version_spec() -> None: + """Examples from the uapi group version format spec""" + assert GenericVersion("11") == GenericVersion("11") + assert GenericVersion("systemd-123") == GenericVersion("systemd-123") + assert GenericVersion("bar-123") < GenericVersion("foo-123") + assert GenericVersion("123a") > GenericVersion("123") + assert GenericVersion("123.a") > GenericVersion("123") + assert GenericVersion("123.a") < GenericVersion("123.b") + assert GenericVersion("123a") > GenericVersion("123.a") + assert GenericVersion("11α") == GenericVersion("11β") + assert GenericVersion("A") < GenericVersion("a") + assert GenericVersion("") < GenericVersion("0") + assert GenericVersion("0.") > GenericVersion("0") + assert GenericVersion("0.0") > GenericVersion("0") + assert GenericVersion("0") > GenericVersion("~") + assert GenericVersion("") > GenericVersion("~") + assert GenericVersion("1_") == GenericVersion("1") + assert GenericVersion("_1") == GenericVersion("1") + assert GenericVersion("1_") < GenericVersion("1.2") + assert GenericVersion("1_2_3") > GenericVersion("1.3.3") + assert GenericVersion("1+") == GenericVersion("1") + assert GenericVersion("+1") == GenericVersion("1") + assert GenericVersion("1+") < GenericVersion("1.2") + assert GenericVersion("1+2+3") > GenericVersion("1.3.3") + + +@pytest.mark.parametrize( + "s1,s2", + itertools.combinations_with_replacement( + enumerate( + [ + GenericVersion("122.1"), + GenericVersion("123~rc1-1"), + GenericVersion("123"), + GenericVersion("123-a"), + GenericVersion("123-a.1"), + GenericVersion("123-1"), + GenericVersion("123-1.1"), + GenericVersion("123^post1"), + GenericVersion("123.a-1"), + GenericVersion("123.1-1"), + GenericVersion("123a-1"), + GenericVersion("124-1"), + ], + ), + 2 + ) +) +def test_generic_version_strverscmp_improved_doc(s1: tuple[int, GenericVersion], s2: tuple[int, GenericVersion]) -> None: + """Example from the doc string of strverscmp_improved in systemd/src/fundamental/string-util-fundamental.c""" + i1, v1 = s1 + i2, v2 = s2 + assert (v1 == v2) == (i1 == i2) + assert (v1 < v2) == (i1 < i2) + assert (v1 <= v2) == (i1 <= i2) + assert (v1 > v2) == (i1 > i2) + assert (v1 >= v2) == (i1 >= i2) + assert (v1 != v2) == (i1 != i2) + + +def RPMVERCMP(a: str, b: str, expected: int) -> None: + assert (GenericVersion(a) > GenericVersion(b)) - (GenericVersion(a) < GenericVersion(b)) == expected + + +def test_generic_version_rpmvercmp() -> None: + # Tests copied from rpm's rpmio test suite, under the LGPL license: + # https://github.com/rpm-software-management/rpm/blob/master/tests/rpmvercmp.at. + # The original form is retained as much as possible for easy comparisons and updates. + + RPMVERCMP("1.0", "1.0", 0) + RPMVERCMP("1.0", "2.0", -1) + RPMVERCMP("2.0", "1.0", 1) + + RPMVERCMP("2.0.1", "2.0.1", 0) + RPMVERCMP("2.0", "2.0.1", -1) + RPMVERCMP("2.0.1", "2.0", 1) + + RPMVERCMP("2.0.1a", "2.0.1a", 0) + RPMVERCMP("2.0.1a", "2.0.1", 1) + RPMVERCMP("2.0.1", "2.0.1a", -1) + + RPMVERCMP("5.5p1", "5.5p1", 0) + RPMVERCMP("5.5p1", "5.5p2", -1) + RPMVERCMP("5.5p2", "5.5p1", 1) + + RPMVERCMP("5.5p10", "5.5p10", 0) + RPMVERCMP("5.5p1", "5.5p10", -1) + RPMVERCMP("5.5p10", "5.5p1", 1) + + RPMVERCMP("10xyz", "10.1xyz", 1) # Note: this is reversed from rpm's vercmp */ + RPMVERCMP("10.1xyz", "10xyz", -1) # Note: this is reversed from rpm's vercmp */ + + RPMVERCMP("xyz10", "xyz10", 0) + RPMVERCMP("xyz10", "xyz10.1", -1) + RPMVERCMP("xyz10.1", "xyz10", 1) + + RPMVERCMP("xyz.4", "xyz.4", 0) + RPMVERCMP("xyz.4", "8", -1) + RPMVERCMP("8", "xyz.4", 1) + RPMVERCMP("xyz.4", "2", -1) + RPMVERCMP("2", "xyz.4", 1) + + RPMVERCMP("5.5p2", "5.6p1", -1) + RPMVERCMP("5.6p1", "5.5p2", 1) + + RPMVERCMP("5.6p1", "6.5p1", -1) + RPMVERCMP("6.5p1", "5.6p1", 1) + + RPMVERCMP("6.0.rc1", "6.0", 1) + RPMVERCMP("6.0", "6.0.rc1", -1) + + RPMVERCMP("10b2", "10a1", 1) + RPMVERCMP("10a2", "10b2", -1) + + RPMVERCMP("1.0aa", "1.0aa", 0) + RPMVERCMP("1.0a", "1.0aa", -1) + RPMVERCMP("1.0aa", "1.0a", 1) + + RPMVERCMP("10.0001", "10.0001", 0) + RPMVERCMP("10.0001", "10.1", 0) + RPMVERCMP("10.1", "10.0001", 0) + RPMVERCMP("10.0001", "10.0039", -1) + RPMVERCMP("10.0039", "10.0001", 1) + + RPMVERCMP("4.999.9", "5.0", -1) + RPMVERCMP("5.0", "4.999.9", 1) + + RPMVERCMP("20101121", "20101121", 0) + RPMVERCMP("20101121", "20101122", -1) + RPMVERCMP("20101122", "20101121", 1) + + RPMVERCMP("2_0", "2_0", 0) + RPMVERCMP("2.0", "2_0", -1) # Note: in rpm those compare equal + RPMVERCMP("2_0", "2.0", 1) # Note: in rpm those compare equal + + # RhBug:178798 case */ + RPMVERCMP("a", "a", 0) + RPMVERCMP("a+", "a+", 0) + RPMVERCMP("a+", "a_", 0) + RPMVERCMP("a_", "a+", 0) + RPMVERCMP("+a", "+a", 0) + RPMVERCMP("+a", "_a", 0) + RPMVERCMP("_a", "+a", 0) + RPMVERCMP("+_", "+_", 0) + RPMVERCMP("_+", "+_", 0) + RPMVERCMP("_+", "_+", 0) + RPMVERCMP("+", "_", 0) + RPMVERCMP("_", "+", 0) + + # Basic testcases for tilde sorting + RPMVERCMP("1.0~rc1", "1.0~rc1", 0) + RPMVERCMP("1.0~rc1", "1.0", -1) + RPMVERCMP("1.0", "1.0~rc1", 1) + RPMVERCMP("1.0~rc1", "1.0~rc2", -1) + RPMVERCMP("1.0~rc2", "1.0~rc1", 1) + RPMVERCMP("1.0~rc1~git123", "1.0~rc1~git123", 0) + RPMVERCMP("1.0~rc1~git123", "1.0~rc1", -1) + RPMVERCMP("1.0~rc1", "1.0~rc1~git123", 1) + + # Basic testcases for caret sorting + RPMVERCMP("1.0^", "1.0^", 0) + RPMVERCMP("1.0^", "1.0", 1) + RPMVERCMP("1.0", "1.0^", -1) + RPMVERCMP("1.0^git1", "1.0^git1", 0) + RPMVERCMP("1.0^git1", "1.0", 1) + RPMVERCMP("1.0", "1.0^git1", -1) + RPMVERCMP("1.0^git1", "1.0^git2", -1) + RPMVERCMP("1.0^git2", "1.0^git1", 1) + RPMVERCMP("1.0^git1", "1.01", -1) + RPMVERCMP("1.01", "1.0^git1", 1) + RPMVERCMP("1.0^20160101", "1.0^20160101", 0) + RPMVERCMP("1.0^20160101", "1.0.1", -1) + RPMVERCMP("1.0.1", "1.0^20160101", 1) + RPMVERCMP("1.0^20160101^git1", "1.0^20160101^git1", 0) + RPMVERCMP("1.0^20160102", "1.0^20160101^git1", 1) + RPMVERCMP("1.0^20160101^git1", "1.0^20160102", -1) + + # Basic testcases for tilde and caret sorting */ + RPMVERCMP("1.0~rc1^git1", "1.0~rc1^git1", 0) + RPMVERCMP("1.0~rc1^git1", "1.0~rc1", 1) + RPMVERCMP("1.0~rc1", "1.0~rc1^git1", -1) + RPMVERCMP("1.0^git1~pre", "1.0^git1~pre", 0) + RPMVERCMP("1.0^git1", "1.0^git1~pre", 1) + RPMVERCMP("1.0^git1~pre", "1.0^git1", -1) + + # These are included here to document current, arguably buggy behaviors + # for reference purposes and for easy checking against unintended + # behavior changes. */ + print("/* RPM version comparison oddities */") + # RhBug:811992 case + RPMVERCMP("1b.fc17", "1b.fc17", 0) + RPMVERCMP("1b.fc17", "1.fc17", 1) # Note: this is reversed from rpm's vercmp, WAT! */ + RPMVERCMP("1.fc17", "1b.fc17", -1) + RPMVERCMP("1g.fc17", "1g.fc17", 0) + RPMVERCMP("1g.fc17", "1.fc17", 1) + RPMVERCMP("1.fc17", "1g.fc17", -1) + + # Non-ascii characters are considered equal so these are all the same, eh… */ + RPMVERCMP("1.1.α", "1.1.α", 0) + RPMVERCMP("1.1.α", "1.1.β", 0) + RPMVERCMP("1.1.β", "1.1.α", 0) + RPMVERCMP("1.1.αα", "1.1.α", 0) + RPMVERCMP("1.1.α", "1.1.ββ", 0) + RPMVERCMP("1.1.ββ", "1.1.αα", 0)