From: Arnab Kumar Singh (arnsingh) Date: Mon, 10 Nov 2025 07:08:09 +0000 (+0000) Subject: Pull request #4961: Fix:Coverity issue due to copy instead of move X-Git-Tag: 3.10.0.0~12 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b87c7c02544ac56e2e00ef123b3f667ba35eb7e4;p=thirdparty%2Fsnort3.git Pull request #4961: Fix:Coverity issue due to copy instead of move Merge in SNORT/snort3 from ~ARNSINGH/snort3:copyinsteadmove to master Squashed commit of the following: commit c2531f56ac8d343f45b5bd4869dfca2621516f4f Author: arnsingh Date: Sun Oct 26 14:25:20 2025 +0530 dce_rpc: changed copy to move --- diff --git a/src/service_inspectors/dce_rpc/dce_smb2_utils.h b/src/service_inspectors/dce_rpc/dce_smb2_utils.h index 7650a37e1..3588a45b3 100644 --- a/src/service_inspectors/dce_rpc/dce_smb2_utils.h +++ b/src/service_inspectors/dce_rpc/dce_smb2_utils.h @@ -132,7 +132,7 @@ inline void DCE2_Smb2InsertSidInSsd(DCE2_Smb2SsnData* ssd, const uint64_t sid, { stracker->insertConnectionTracker(ssd->flow_key, ssd); } - ssd->insert_session_tracker(sid, stracker); + ssd->insert_session_tracker(sid, std::move(stracker)); } inline void DCE2_Smb2RemoveSidInSsd(DCE2_Smb2SsnData* ssd, const uint64_t sid)