From: Nikanth Karthikesan <knikanth@suse.de>
Date: Sun, 16 May 2010 18:00:00 +0000 (-0400)
Subject: ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
X-Git-Tag: v2.6.33.8~298
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b87c9ea0ff8b0f8e7ff538e1d47a20933b229403;p=thirdparty%2Fkernel%2Fstable.git

ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate

commit 6d19c42b7cf81c39632b6d4dbc514e8449bcd346 upstream.

Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a file larger than the limit. Add a check for that.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Signed-off-by: Amit Arora <aarora@in.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 1667fac41f32c..505a28177b8d1 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3545,6 +3545,11 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
 	 */
 	credits = ext4_chunk_trans_blocks(inode, max_blocks);
 	mutex_lock(&inode->i_mutex);
+	ret = inode_newsize_ok(inode, (len + offset));
+	if (ret) {
+		mutex_unlock(&inode->i_mutex);
+		return ret;
+	}
 retry:
 	while (ret >= 0 && ret < max_blocks) {
 		block = block + ret;