From: William Lallemand <wlallemand@haproxy.org>
Date: Wed, 27 Jan 2021 13:42:40 +0000 (+0100)
Subject: CLEANUP: ssl: remove dead code in ckch_inst_new_load_srv_store()
X-Git-Tag: v2.4-dev7~123
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8868498edd1e005414fb44d6cf91e44b45ca191;p=thirdparty%2Fhaproxy.git

CLEANUP: ssl: remove dead code in ckch_inst_new_load_srv_store()

The new ckch_inst_new_load_srv_store() function which mimics the
ckch_inst_new_load_store() function includes some dead code which was
used only in the former function.

Fix issue #1081.
---

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index ee52aa0573..c25f447fba 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -3499,11 +3499,6 @@ int ckch_inst_new_load_srv_store(const char *path, struct ckch_store *ckchs,
 	return errcode;
 
 error:
-	/* free the allocated sni_ctxs */
-	if (ckch_inst) {
-		ckch_inst_free(ckch_inst);
-		ckch_inst = NULL;
-	}
 	SSL_CTX_free(ctx);
 
 	return errcode;