From: Daniel Axtens Date: Mon, 18 Jan 2021 06:17:16 +0000 (+1100) Subject: fs/btrfs: Validate the number of stripes/parities in RAID5/6 X-Git-Tag: grub-2.06-rc1~50 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b88a82e78cdd0ab8e0339c1c3f9564c4d8c0c969;p=thirdparty%2Fgrub.git fs/btrfs: Validate the number of stripes/parities in RAID5/6 This prevents a divide by zero if nstripes == nparities, and also prevents propagation of invalid values if nstripes ends up less than nparities. Signed-off-by: Daniel Axtens Reviewed-by: Daniel Kiper --- diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index 27339bdb3..c4ba5f110 100644 --- a/grub-core/fs/btrfs.c +++ b/grub-core/fs/btrfs.c @@ -1083,6 +1083,9 @@ grub_btrfs_read_logical (struct grub_btrfs_data *data, grub_disk_addr_t addr, * stripen is computed without the parities * (0 for A0, A1, A2, 1 for B0, B1, B2, etc.). */ + if (nparities >= nstripes) + return grub_error (GRUB_ERR_BAD_FS, + "invalid RAID5/6: nparities >= nstripes"); high = grub_divmod64 (stripe_nr, nstripes - nparities, &stripen); /*