From: Ján Tomko <jtomko@redhat.com>
Date: Wed, 18 May 2022 13:56:23 +0000 (+0200)
Subject: src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported
X-Git-Tag: v8.5.0-rc1~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8a2d9675875cb9cd117025ebd48c9c31c6affb6;p=thirdparty%2Flibvirt.git

src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported

The result of the <= 0 comparison was assigned to 'rc', rendering the
if (rc == 0) condition dead code.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index 5020b5dc1b..ace91e8ada 100644
--- a/src/libvirt-qemu.c
+++ b/src/libvirt-qemu.c
@@ -161,7 +161,7 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domain,
     if (ninfiles > 0 || outfiles) {
         int rc;
         if ((rc = VIR_DRV_SUPPORTS_FEATURE(conn->driver, conn,
-                                           VIR_DRV_FEATURE_FD_PASSING) <= 0)) {
+                                           VIR_DRV_FEATURE_FD_PASSING)) <= 0) {
             if (rc == 0)
                 virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
                                _("fd passing is not supported by this connection"));