From: Harald Hoyer <harald@redhat.com>
Date: Fri, 26 Mar 2021 09:29:07 +0000 (+0100)
Subject: fix(systemd-coredump): shellcheck for modules.d/01systemd-coredump
X-Git-Tag: 054~271
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8ca67280fe1b78eff2e65d9e58c567d28abfb3e;p=thirdparty%2Fdracut.git

fix(systemd-coredump): shellcheck for modules.d/01systemd-coredump
---

diff --git a/modules.d/01systemd-coredump/.shchkdir b/modules.d/01systemd-coredump/.shchkdir
new file mode 100644
index 000000000..e69de29bb
diff --git a/modules.d/01systemd-coredump/module-setup.sh b/modules.d/01systemd-coredump/module-setup.sh
index 14cad5eff..5b8b75ac8 100755
--- a/modules.d/01systemd-coredump/module-setup.sh
+++ b/modules.d/01systemd-coredump/module-setup.sh
@@ -7,7 +7,7 @@ check() {
 
     # If the binary(s) requirements are not fulfilled the module can't be installed
     require_binaries coredumpctl || return 1
-    require_binaries $systemdutildir/systemd-coredump || return 1
+    require_binaries "$systemdutildir"/systemd-coredump || return 1
 
     # Return 255 to only include the module, if another module requires it.
     return 255
@@ -29,23 +29,23 @@ install() {
 
     inst_dir /var/lib/systemd/coredump
     inst_multiple -o \
-        $sysctld/50-coredump.conf \
-        $systemdutildir/coredump.conf \
-        $systemdsystemunitdir/systemd-coredump \
-        $systemdsystemunitdir/systemd-coredump.socket \
-        $systemdsystemunitdir/systemd-coredump@.service $systemdsystemunitdir/sockets.target.wants/systemd-coredump.socket \
+        "$sysctld"/50-coredump.conf \
+        "$systemdutildir"/coredump.conf \
+        "$systemdsystemunitdir"/systemd-coredump \
+        "$systemdsystemunitdir"/systemd-coredump.socket \
+        "$systemdsystemunitdir"/systemd-coredump@.service \
+        "$systemdsystemunitdir"/sockets.target.wants/systemd-coredump.socket \
         coredumpctl
 
     # Install the hosts local user configurations if enabled.
     if [[ $hostonly ]]; then
         inst_multiple -H -o \
-            $systemdutilconfdir/coredump.conf \
-            $systemdsystemconfdir/coredump.conf.d/*.conf \
-            $systemdsystemconfdir/systemd-coredump.socket \
-            $systemdsystemconfdir/systemd-coredump.socket.d/*.conf \
-            $systemdsystemconfdir/systemd-coredump@.service \
-            $systemdsystemconfdir/systemd-coredump@.service.d/*.conf \
-            $systemdsystemconfdir/sockets.target.wants/systemd-coredump.socket \
-            ${NULL}
+            "$systemdutilconfdir"/coredump.conf \
+            "$systemdsystemconfdir"/coredump.conf.d/*.conf \
+            "$systemdsystemconfdir"/systemd-coredump.socket \
+            "$systemdsystemconfdir"/systemd-coredump.socket.d/*.conf \
+            "$systemdsystemconfdir"/systemd-coredump@.service \
+            "$systemdsystemconfdir"/systemd-coredump@.service.d/*.conf \
+            "$systemdsystemconfdir"/sockets.target.wants/systemd-coredump.socket
     fi
 }