From: Ruben Kerkhof <ruben@rubenkerkhof.com>
Date: Sat, 3 Jan 2015 16:06:04 +0000 (+0100)
Subject: Fix race condition in generating header
X-Git-Tag: rec-3.7.0-rc1~67^2~5^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8cab7e247e53d4b901b9b78f6d0b11e990e9e90;p=thirdparty%2Fpdns.git

Fix race condition in generating header

Use a define to create the file in one go.
Fixes #1853
---

diff --git a/pdns/Makefile.am b/pdns/Makefile.am
index 0b0ee94c5f..eef73aa928 100644
--- a/pdns/Makefile.am
+++ b/pdns/Makefile.am
@@ -976,10 +976,16 @@ pubsuffix.cc: $(srcdir)/effective_tld_names.dat
 
 .PHONY: version_generated.h
 version_generated.h:
-	@echo '#ifndef VERSION_GENERATED_H' > $@
-	@echo '#define VERSION_GENERATED_H' >> $@
-	@echo '#define PDNS_VERSION "$(pdns_version)"' >> $@
-	@echo '#define DIST_HOST "$(dist_host)"' >> $@
-	@echo '#define BUILD_DATE "$(build_date)"' >> $@
-	@echo '#define BUILD_HOST "$(build_host)"' >> $@
-	@echo '#endif //!VERSION_GENERATED_H' >> $@
+	@echo "$$create_version_generated_h" > $@
+
+define create_version_generated_h
+#ifndef VERSION_GENERATED_H
+#define VERSION_GENERATED_H
+#define PDNS_VERSION "$(pdns_version)"
+#define DIST_HOST "$(dist_host)"
+#define BUILD_DATE "$(build_date)"
+#define BUILD_HOST "$(build_host)"
+#endif //!VERSION_GENERATED_H
+endef
+
+export create_version_generated_h