From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 14 Feb 2017 16:31:54 +0000 (-0500)
Subject: freeing memory is good, too
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8e3ac16989502c8a7ef28b2e174a407681b4562;p=thirdparty%2Ffreeradius-server.git

freeing memory is good, too
---

diff --git a/src/main/unit_test_attribute.c b/src/main/unit_test_attribute.c
index a677555c40f..ffc6de2c53a 100644
--- a/src/main/unit_test_attribute.c
+++ b/src/main/unit_test_attribute.c
@@ -907,12 +907,14 @@ static void process_file(fr_dict_t *dict, const char *root_dir, char const *file
 
 			if (fr_pair_list_afrom_str(packet, p, &head) != T_EOL) {
 				strlcpy(output, fr_strerror(), sizeof(output));
+				talloc_free(packet);
 				continue;
 			}
 
 			packet->vps = head;
 			if (tacacs_encode(packet, NULL) < 0) {
 				strlcpy(output, fr_strerror(), sizeof(output));
+				talloc_free(packet);
 				continue;
 			}
 
@@ -948,6 +950,7 @@ static void process_file(fr_dict_t *dict, const char *root_dir, char const *file
 
 			if (tacacs_decode(packet) < 0) {
 				strlcpy(output, fr_strerror(), sizeof(output));
+				talloc_free(packet);
 				continue;
 			}
 
@@ -964,7 +967,6 @@ static void process_file(fr_dict_t *dict, const char *root_dir, char const *file
 			}
 
 			talloc_free(packet);
-
 			continue;
 		}
 #endif	/* WITH_TACACS */