From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 19 May 2022 14:48:26 +0000 (-0400)
Subject: this loop isn't necessary.  It's done by xlat_copy.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8f264c93a5b27b700fd1bd1dd4a3375cc2f4c58;p=thirdparty%2Ffreeradius-server.git

this loop isn't necessary.  It's done by xlat_copy.
---

diff --git a/src/lib/unlang/xlat_tokenize.c b/src/lib/unlang/xlat_tokenize.c
index 9f69a5195b7..a39c7f2e19b 100644
--- a/src/lib/unlang/xlat_tokenize.c
+++ b/src/lib/unlang/xlat_tokenize.c
@@ -126,13 +126,7 @@ xlat_exp_t *xlat_exp_func_alloc(TALLOC_CTX *ctx, xlat_t *func, xlat_exp_head_t c
 		return NULL;
 	}
 	node->flags = func->flags;
-
-	/*
-	 *	A pure function can have impure arguments, e.g. hash(sql query).
-	 */
-	xlat_exp_foreach(args, arg) {
-		xlat_flags_merge(&node->flags, &arg->flags);
-	}
+	xlat_flags_merge(&node->flags, &args->flags);
 
 	return node;
 }