From: Kruti Date: Tue, 21 May 2024 05:58:12 +0000 (-0700) Subject: Change to common source file not directly applicable to open-vm-tools. X-Git-Tag: stable-12.5.0~72 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b8fbf56a86b2d7e3d937fba9858add64d9792e8b;p=thirdparty%2Fopen-vm-tools.git Change to common source file not directly applicable to open-vm-tools. --- diff --git a/open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c b/open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c index 917e49f4b..10e5cc83d 100644 --- a/open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c +++ b/open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c @@ -1424,9 +1424,10 @@ VerifySignature(xmlDocPtr doc, * dsigCtx->status can be at the wrong offset. So * dump the value of status, which should be either * 1 (xmlSecDSigStatusSucceeded) or 2 (xmlSecDSigStatusInvalid). - * If its something else, that's a sign there's a - * build issue and XMLSEC_NO_SIZE_T may be set at one layer but - * not the other. + * If its something else, that could be a sign that there's a build issue + * and that libxmlsec1 is using a different size type than its callers. + * Please see xmlSecSize changelog in + * https://www.aleksey.com/xmlsec/news.html * */ if (dsigCtx->status != xmlSecDSigStatusSucceeded) { diff --git a/open-vm-tools/vgauth/test/README.txt b/open-vm-tools/vgauth/test/README.txt index ae1d8a462..55790a8e0 100644 --- a/open-vm-tools/vgauth/test/README.txt +++ b/open-vm-tools/vgauth/test/README.txt @@ -31,7 +31,7 @@ * - SAML verification failed to init (xmlsec1 build issues) * - token fails to validate * - this test was run after 12/18/3015 - * - xmlsec1-config lies about how xmlsec1 was built - * some packages leave out -DXMLSEC_NO_SIZE_T, - * which can make some data structures a different size - * than in the library + * - libxmlsec1 may have been built using a different size type than + * its callers, which can make some data structures a different size + * than in the library. See xmlSecSize changelog in + * https://www.aleksey.com/xmlsec/news.html