From: Timo Sirainen Date: Sat, 14 Sep 2019 09:59:06 +0000 (+0300) Subject: login-proxy: Fix potential crash if ssl_iostream_handshake() fails X-Git-Tag: 2.3.9~88 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b907ec5c0d5f2b20a7a6abd9ac3e659b4c6b8d50;p=thirdparty%2Fdovecot%2Fcore.git login-proxy: Fix potential crash if ssl_iostream_handshake() fails The error was uninitialized, which could have caused a crash when it was logged (or just "(null)" printed with better luck). --- diff --git a/src/login-common/login-proxy.c b/src/login-common/login-proxy.c index 717481672e..1888060731 100644 --- a/src/login-common/login-proxy.c +++ b/src/login-common/login-proxy.c @@ -719,7 +719,8 @@ int login_proxy_starttls(struct login_proxy *proxy) error = ssl_iostream_get_last_error(proxy->server_ssl_iostream); client_log_err(proxy->client, t_strdup_printf( "proxy: Failed to start SSL handshake to %s:%u: %s", - net_ip2addr(&proxy->ip), proxy->port, error)); + net_ip2addr(&proxy->ip), proxy->port, + ssl_iostream_get_last_error(proxy->server_ssl_iostream))); return -1; }