From: Gedalya <gedalya@gedalya.net>
Date: Tue, 3 Jan 2023 11:39:36 +0000 (+0800)
Subject: Fix null pointer dereference in virXMLPropStringRequired
X-Git-Tag: v9.0.0-rc1~132
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9315159f5fc50fc54bb0a573b42f21bda23e0ce;p=thirdparty%2Flibvirt.git

Fix null pointer dereference in virXMLPropStringRequired

Fixes: 65eaf58335f

Signed-off-by: Gedalya <gedalya@gedalya.net>
---

diff --git a/src/util/virxml.c b/src/util/virxml.c
index 7d9d4bb234..9b6ccfd6c9 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -320,7 +320,7 @@ virXMLPropStringRequired(xmlNodePtr node,
 {
     char *ret = virXMLPropString(node, name);
 
-     if (!(*ret))
+     if (!ret)
          virReportError(VIR_ERR_XML_ERROR,
                         _("Missing required attribute '%s' in element '%s'"),
                         name, node->name);