From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Mon, 30 May 2022 08:18:46 +0000 (+0200)
Subject: BUG/MINOR: h3: do not report bug on unknown method
X-Git-Tag: v2.6.0~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b93399a5e7714a5e440add58a5f09c100d65fc01;p=thirdparty%2Fhaproxy.git

BUG/MINOR: h3: do not report bug on unknown method

Remove an unneeded BUG_ON statement when find_http_meth() returns
HTTP_METH_OTHER.

This fix is necessary to support requests with unusual methods with
DEBUG_STRICT activated. This was detected when browsing with HTTP/3 over
a nextcloud instance which uses PROPFIND method for Webdav.
---

diff --git a/src/h3.c b/src/h3.c
index 14ae2c4a2b..3ff45ffe1c 100644
--- a/src/h3.c
+++ b/src/h3.c
@@ -321,7 +321,6 @@ static int h3_headers_to_htx(struct qcs *qcs, struct ncbuf *buf, uint64_t len,
 		sl->flags |= HTX_SL_F_BODYLESS;
 
 	sl->info.req.meth = find_http_meth(meth.ptr, meth.len);
-	BUG_ON(sl->info.req.meth == HTTP_METH_OTHER);
 
 	if (isttest(authority))
 		htx_add_header(htx, ist("host"), authority);