From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 11 Jun 2025 09:14:15 +0000 (+0200)
Subject: http_ntlm: remove unreachable code
X-Git-Tag: curl-8_15_0~280
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b950c8c03f638d986a5650a7ea7fda61bde3baf7;p=thirdparty%2Fcurl.git

http_ntlm: remove unreachable code

Since the code now checks for NULL and returns before this point, 'ntlm'
cannot be NULL at this point in the code. Pointed out by Coverity.

Follow-up to 55865207457ba860956aea7a31a

Closes #17587
---

diff --git a/lib/http_ntlm.c b/lib/http_ntlm.c
index 8c2ff40480..0dff8f3a00 100644
--- a/lib/http_ntlm.c
+++ b/lib/http_ntlm.c
@@ -202,9 +202,8 @@ CURLcode Curl_output_ntlm(struct Curl_easy *data, bool proxy)
   case NTLMSTATE_TYPE1:
   default: /* for the weird cases we (re)start here */
     /* Create a type-1 message */
-    result = !ntlm ? CURLE_OUT_OF_MEMORY :
-      Curl_auth_create_ntlm_type1_message(data, userp, passwdp, service,
-                                          hostname, ntlm, &ntlmmsg);
+    result = Curl_auth_create_ntlm_type1_message(data, userp, passwdp, service,
+                                                 hostname, ntlm, &ntlmmsg);
     if(!result) {
       DEBUGASSERT(Curl_bufref_len(&ntlmmsg) != 0);
       result = curlx_base64_encode((const char *) Curl_bufref_ptr(&ntlmmsg),