From: Ondrej Zajicek <santiago@crfreenet.org>
Date: Thu, 23 Apr 2009 10:36:24 +0000 (+0200)
Subject: Fixes bug in BGPv6 causing crash by checking missing attributes.
X-Git-Tag: v1.2.0~119
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9539e78d8ebfa9e13d7b61ec9278b76abefdac3;p=thirdparty%2Fbird.git

Fixes bug in BGPv6 causing crash by checking missing attributes.
---

diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c
index b7c5f2ebc..57dce1467 100644
--- a/proto/bgp/attrs.c
+++ b/proto/bgp/attrs.c
@@ -1359,17 +1359,19 @@ bgp_decode_attrs(struct bgp_conn *conn, byte *attr, unsigned int len, struct lin
     mandatory = 1;
 #endif
 
+
+  /* If there is no (reachability) NLRI, we should exit now */
+  if (! mandatory)
+    return a;
+
   /* Check if all mandatory attributes are present */
-  if (mandatory)
+  for(i=0; i < ARRAY_SIZE(bgp_mandatory_attrs); i++)
     {
-      for(i=0; i < ARRAY_SIZE(bgp_mandatory_attrs); i++)
+      code = bgp_mandatory_attrs[i];
+      if (!(seen[code/8] & (1 << (code%8))))
 	{
-	  code = bgp_mandatory_attrs[i];
-	  if (!(seen[code/8] & (1 << (code%8))))
-	    {
-	      bgp_error(conn, 3, 3, &bgp_mandatory_attrs[i], 1);
-	      return NULL;
-	    }
+	  bgp_error(conn, 3, 3, &bgp_mandatory_attrs[i], 1);
+	  return NULL;
 	}
     }