From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 9 Dec 2016 20:37:39 +0000 (-0800)
Subject: Revert "devlink: Add usage help for eswitch subcommand"
X-Git-Tag: v4.9.0~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b95e5c55a9aa35750f7e9241bda4b3f59050cbb0;p=thirdparty%2Fiproute2.git

Revert "devlink: Add usage help for eswitch subcommand"

This reverts commit 11f4cd31d2776bbffecceb6775d0210fe16cc04e.
---

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 673234fa7..ccca0fb39 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -963,8 +963,6 @@ static bool dl_dump_filter(struct dl *dl, struct nlattr **tb)
 static void cmd_dev_help(void)
 {
 	pr_err("Usage: devlink dev show [ DEV ]\n");
-	pr_err("       devlink dev eswitch set DEV [ mode { legacy | switchdev } ]\n");
-	pr_err("       devlink dev eswitch show DEV\n");
 }
 
 static bool cmp_arr_last_handle(struct dl *dl, const char *bus_name,
@@ -1261,10 +1259,7 @@ static int cmd_dev_eswitch_set(struct dl *dl)
 
 static int cmd_dev_eswitch(struct dl *dl)
 {
-	if (dl_argv_match(dl, "help") || dl_no_arg(dl)) {
-		cmd_dev_help();
-		return 0;
-	} else if (dl_argv_match(dl, "set")) {
+	if (dl_argv_match(dl, "set")) {
 		dl_arg_inc(dl);
 		return cmd_dev_eswitch_set(dl);
 	} else if (dl_argv_match(dl, "show")) {
diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8
index 931e334da..9ce319374 100644
--- a/man/man8/devlink-dev.8
+++ b/man/man8/devlink-dev.8
@@ -54,7 +54,7 @@ BUS_NAME/BUS_ADDRESS
 
 .TP
 .BR mode " { " legacy " | " switchdev " } "
-Set eswitch mode
+set eswitch mode
 
 .I legacy
 - Legacy SRIOV