From: Nikhil Mahale Date: Wed, 9 Aug 2017 03:53:01 +0000 (+0530) Subject: drm: Fix framebuffer leak X-Git-Tag: v4.12.10~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b96c156551250c20042074cb67c221ea64058a98;p=thirdparty%2Fkernel%2Fstable.git drm: Fix framebuffer leak commit 491ab4700d1b64f5cf2f9055e01613a923df5fab upstream. Do not leak framebuffer if client provided crtc id found invalid. Signed-off-by: Nikhil Mahale Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/1502250781-5779-1-git-send-email-nmahale@nvidia.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 5dc8c4350602a..e40c12fabbdea 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -601,6 +601,7 @@ int drm_mode_setplane(struct drm_device *dev, void *data, crtc = drm_crtc_find(dev, plane_req->crtc_id); if (!crtc) { + drm_framebuffer_put(fb); DRM_DEBUG_KMS("Unknown crtc ID %d\n", plane_req->crtc_id); return -ENOENT;