From: Ralph Boehme <slow@samba.org>
Date: Fri, 15 Jan 2021 15:37:56 +0000 (+0100)
Subject: vfs: directory enumeration is now handle based
X-Git-Tag: samba-4.14.0rc1~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b96c2cf0199495b32dbdce5c833a0b64a9c4bd5d;p=thirdparty%2Fsamba.git

vfs: directory enumeration is now handle based

Remove obsolete description. Also remove SMB_VFS_STATX() as I don't see a need
for that atm.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 15 22:01:55 UTC 2021 on sn-devel-184
---

diff --git a/source3/modules/The_New_VFS.org b/source3/modules/The_New_VFS.org
index ad319c5cfba..d034acaa661 100644
--- a/source3/modules/The_New_VFS.org
+++ b/source3/modules/The_New_VFS.org
@@ -310,7 +310,6 @@ whenever VFS access is done in a piecemeal fashion.
 |---------------------------------+----------+--------|
 | SMB_VFS_SYS_ACL_DELETE_DEF_FD() | [[xpathref][xpathref]] | Todo   |
 | SMB_VFS_READDIR_ATTRAT()        | [[Enum][Enum]]     | Todo   |
-| SMB_VFS_STATX()                 | [[Enum][Enum]]     | Todo   |
 | SMB_VFS_FUTIMENS()              | [[fsp][fsp]]      | Todo   |
 |---------------------------------+----------+--------|
 
@@ -437,16 +436,9 @@ whenever VFS access is done in a piecemeal fashion.
  functions with real dirfsps.
 
 *** AT VFS functions needed for directory enumeration <<Enum>>
-
  - SMB_VFS_GET_DOS_ATTRIBUTES_SEND()
  - SMB_VFS_GETXATTRAT_SEND()
  - SMB_VFS_READDIR_ATTRAT() (NEW)
- - SMB_VFS_STATX() (NEW)
-
- We can't open file-handles on all directory children for performance
- reasons. Therefor we need *AT based VFS functions for all metadata VFS queries
- done in the directory enumeration loop.
-
 *** Handle based VFS functions not allowed on O_PATH opened handles <<xpathref>>
  - SMB_VFS_FGETXATTR()
  - SMB_VFS_FLISTXATTR()
diff --git a/source3/modules/The_New_VFS.txt b/source3/modules/The_New_VFS.txt
index 845555b2794..6d94cfdc6a2 100644
--- a/source3/modules/The_New_VFS.txt
+++ b/source3/modules/The_New_VFS.txt
@@ -400,7 +400,6 @@ Table of Contents
   ─────────────────────────────────────────────────────
    SMB_VFS_SYS_ACL_DELETE_DEF_FD()  [xpathref]  Todo
    SMB_VFS_READDIR_ATTRAT()         [Enum]      Todo
-   SMB_VFS_STATX()                  [Enum]      Todo
    SMB_VFS_FUTIMENS()               [fsp]       Todo
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
@@ -558,11 +557,6 @@ Table of Contents
   • SMB_VFS_GET_DOS_ATTRIBUTES_SEND()
   • SMB_VFS_GETXATTRAT_SEND()
   • SMB_VFS_READDIR_ATTRAT() (NEW)
-  • SMB_VFS_STATX() (NEW)
-
-  We can't open file-handles on all directory children for performance
-  reasons. Therefor we need *AT based VFS functions for all metadata VFS
-  queries done in the directory enumeration loop.
 
 
 2.2.7 Handle based VFS functions not allowed on O_PATH opened handles