From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 1 Sep 2023 01:26:04 +0000 (+1200)
Subject: s4:scripting: Prefer ‘x not in y’ to ‘not x in y’
X-Git-Tag: tevent-0.16.0~608
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b96c55c28a2f3e7a140c4b05903a54ea0577f3f0;p=thirdparty%2Fsamba.git

s4:scripting: Prefer ‘x not in y’ to ‘not x in y’

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/scripting/bin/samba_dnsupdate b/source4/scripting/bin/samba_dnsupdate
index 8ab78708f45..6d9d5bc3dee 100755
--- a/source4/scripting/bin/samba_dnsupdate
+++ b/source4/scripting/bin/samba_dnsupdate
@@ -906,7 +906,7 @@ for d in delete_list:
             if opts.verbose:
                 print("skip delete (rodc): %s" % d)
             continue
-        if not d.type in [ 'A', 'AAAA' ]:
+        if d.type not in [ 'A', 'AAAA' ]:
             if opts.verbose:
                 print("delete (rodc): %s" % d)
             call_rodc_update(d, op="delete")
@@ -931,7 +931,7 @@ for d in update_list:
             if opts.verbose:
                 print("skip (rodc): %s" % d)
             continue
-        if not d.type in [ 'A', 'AAAA' ]:
+        if d.type not in [ 'A', 'AAAA' ]:
             if opts.verbose:
                 print("update (rodc): %s" % d)
             call_rodc_update(d)