From: Tim Wiederhake <twiederh@redhat.com>
Date: Fri, 23 Apr 2021 15:39:15 +0000 (+0200)
Subject: virDomainGraphicsDefParseXMLDesktop: Use virXMLProp*
X-Git-Tag: v7.3.0-rc1~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b975a8a755b192f5980a14c46e745a92d3cdd3be;p=thirdparty%2Flibvirt.git

virDomainGraphicsDefParseXMLDesktop: Use virXMLProp*

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 5b0e90f234..d57450b3c0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -12885,18 +12885,13 @@ static int
 virDomainGraphicsDefParseXMLDesktop(virDomainGraphicsDef *def,
                                     xmlNodePtr node)
 {
-    g_autofree char *fullscreen = virXMLPropString(node, "fullscreen");
+    virTristateBool fullscreen = VIR_TRISTATE_BOOL_NO;
 
-    if (fullscreen != NULL) {
-        if (virStringParseYesNo(fullscreen, &def->data.desktop.fullscreen) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("unknown fullscreen value '%s'"), fullscreen);
-            return -1;
-        }
-    } else {
-        def->data.desktop.fullscreen = false;
-    }
+    if (virXMLPropTristateBool(node, "fullscreen", VIR_XML_PROP_NONE,
+                               &fullscreen) < 0)
+        return -1;
 
+    def->data.desktop.fullscreen = fullscreen == VIR_TRISTATE_BOOL_YES;
     def->data.desktop.display = virXMLPropString(node, "display");
 
     return 0;