From: David Disseldorp Date: Thu, 5 Jan 2017 16:10:42 +0000 (+0100) Subject: torture/ioctl: test set_compression(format_none) X-Git-Tag: samba-4.4.10~77 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b975c76326189552fdf0efeebc63f525fa0a848f;p=thirdparty%2Fsamba.git torture/ioctl: test set_compression(format_none) This test case was overlooked in the previous bso#12144 update - set compression requests with format=COMPRESSION_FORMAT_NONE should succeed if the server / backing storage doesn't offer compression support. Confirm that Samba matches Windows Server 2016 ReFS behaviour here. Bug: https://bugzilla.samba.org/show_bug.cgi?id=12144 Reported-by: Nick Barrett Signed-off-by: David Disseldorp Reviewed-by: Jeremy Allison (cherry picked from commit 6fde123176409e261d955e24b3d28e5124f33bed) --- diff --git a/source4/torture/smb2/ioctl.c b/source4/torture/smb2/ioctl.c index 5fc03bccec0..43488626b9b 100644 --- a/source4/torture/smb2/ioctl.c +++ b/source4/torture/smb2/ioctl.c @@ -2608,7 +2608,16 @@ static bool test_ioctl_compress_notsup_set(struct torture_context *torture, COMPRESSION_FORMAT_DEFAULT); torture_assert_ntstatus_equal(torture, status, NT_STATUS_NOT_SUPPORTED, - "FSCTL_GET_COMPRESSION"); + "FSCTL_SET_COMPRESSION default"); + + /* + * Despite not supporting compression, we should get a successful + * response for set(COMPRESSION_FORMAT_NONE) - like WS2016 ReFS. + */ + status = test_ioctl_compress_set(torture, tmp_ctx, tree, fh, + COMPRESSION_FORMAT_NONE); + torture_assert_ntstatus_ok(torture, status, + "FSCTL_SET_COMPRESSION none"); smb2_util_close(tree, fh); talloc_free(tmp_ctx);