From: Greg Kroah-Hartman Date: Tue, 17 Jun 2025 13:42:12 +0000 (+0200) Subject: Revert "io_uring: ensure deferred completions are posted for multishot" X-Git-Tag: v6.1.142~239 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9794e5d73cc9c8e4c4f657449d362001cfc11d7;p=thirdparty%2Fkernel%2Fstable.git Revert "io_uring: ensure deferred completions are posted for multishot" This reverts commit b82c386898f7b00cb49abe3fbd622017aaa61230 which is commit 687b2bae0efff9b25e071737d6af5004e6e35af5 upstream. Jens writes: There's some missing dependencies that makes this not work right, I'll bring it back in a series instead. Link: https://lore.kernel.org/r/313f2335-626f-4eea-8502-d5c3773db35a@kernel.dk Reported-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index ad462724246a7..abefc334cf7d1 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -820,14 +820,6 @@ bool io_post_aux_cqe(struct io_ring_ctx *ctx, { bool filled; - /* - * If multishot has already posted deferred completions, ensure that - * those are flushed first before posting this one. If not, CQEs - * could get reordered. - */ - if (!wq_list_empty(&ctx->submit_state.compl_reqs)) - __io_submit_flush_completions(ctx); - io_cq_lock(ctx); filled = io_fill_cqe_aux(ctx, user_data, res, cflags, allow_overflow); io_cq_unlock_post(ctx);