From: XhmikosR Date: Sat, 20 Jun 2020 16:07:20 +0000 (+0300) Subject: scrollspy.js: minor refactoring X-Git-Tag: v5.0.0-alpha2~181 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b97fcd32899f3aff87b2885dedd99fd8634c0de9;p=thirdparty%2Fbootstrap.git scrollspy.js: minor refactoring --- diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js index 9156223111..6f7dd04f27 100644 --- a/js/src/scrollspy.js +++ b/js/src/scrollspy.js @@ -113,18 +113,13 @@ class ScrollSpy { this._offsets = [] this._targets = [] - this._scrollHeight = this._getScrollHeight() const targets = SelectorEngine.find(this._selector) targets.map(element => { - let target const targetSelector = getSelectorFromElement(element) - - if (targetSelector) { - target = SelectorEngine.findOne(targetSelector) - } + const target = targetSelector ? SelectorEngine.findOne(targetSelector) : null if (target) { const targetBCR = target.getBoundingClientRect()