From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 13 Oct 2012 06:03:00 +0000 (-0600)
Subject: ssl_crtd: set new certificate serial number to zero
X-Git-Tag: SQUID_3_3_0_1~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9eaed49f9f05ee1a9f4a99474449d57862f6e75;p=thirdparty%2Fsquid.git

ssl_crtd: set new certificate serial number to zero

Initialize new BN value to zero instead of simply testing and ignoring
the result.

Detected by Jenkins running clang on FreeBSD 9.
---

diff --git a/src/ssl/gadgets.cc b/src/ssl/gadgets.cc
index 9e0215d7a0..ac94bc165c 100644
--- a/src/ssl/gadgets.cc
+++ b/src/ssl/gadgets.cc
@@ -435,7 +435,7 @@ static bool createSerial(Ssl::BIGNUM_Pointer &serial, Ssl::CertificateProperties
     serial.reset(x509Pubkeydigest(properties.signWithX509));
     if (!serial.get()) {
         serial.reset(BN_new());
-        BN_is_zero(serial.get());
+        BN_zero(serial.get());
     }
 
     if (!generateFakeSslCertificate(fakeCert, fakePkey, properties, serial))