From: Andrea Bolognani <abologna@redhat.com>
Date: Fri, 9 Feb 2018 15:56:13 +0000 (+0100)
Subject: qemu: Error out on invalid pci-root controller model name
X-Git-Tag: v4.1.0-rc1~132
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9f2a3e6b26d1ec8cb6a6cc91bafecc69ffc030c;p=thirdparty%2Flibvirt.git

qemu: Error out on invalid pci-root controller model name

This is a hard error, and should be handled as such.
Introduced in 24614760228b.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 16833474a1..178ec24ae7 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4446,7 +4446,7 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *controlle
                            _("PCI controller model name '%s' is not valid "
                              "for a pci-root"),
                            modelName);
-            return 0;
+            return -1;
         }
 
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE)) {