From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 6 Mar 2024 21:53:44 +0000 (-0600)
Subject: Remove clang scan hack
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba1106a7c01535ac71173bfd29fce6d339dcd2cd;p=thirdparty%2Ffreeradius-server.git

Remove clang scan hack
---

diff --git a/src/lib/util/pair.c b/src/lib/util/pair.c
index 8010c54aef8..e8fb882cd51 100644
--- a/src/lib/util/pair.c
+++ b/src/lib/util/pair.c
@@ -2053,7 +2053,6 @@ int fr_pair_list_cmp(fr_pair_list_t const *a, fr_pair_list_t const *b)
  *
  * @todo add thread specific talloc contexts.
  *
- * @param ctx a hack until we have thread specific talloc contexts.
  * @param failed pair of attributes which didn't match.
  */
 void fr_pair_validate_debug(fr_pair_t const *failed[2])
@@ -2077,10 +2076,6 @@ void fr_pair_validate_debug(fr_pair_t const *failed[2])
 		return;
 	}
 
-#ifdef STATIC_ANALYZER
-	if (!value || !str) return;
-#endif
-
 	fr_strerror_printf("Attribute value: \"%pP\" didn't match filter: \"%pP\"", list, filter);
 
 	return;