From: Luca Bruno <luca.bruno@immobiliare.it>
Date: Thu, 4 Sep 2014 16:26:21 +0000 (+0200)
Subject: Fix regression when assigning owned expressions to unowned variables.
X-Git-Tag: 0.25.4~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba1fa0759989dcbb9046c7dfc06cce6c4aa23411;p=thirdparty%2Fvala.git

Fix regression when assigning owned expressions to unowned variables.

The regression was introduced by db462e6f919da758fb.

Fixes bug 736016
---

diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index 0cdd8787f..2f1be1b7e 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -892,8 +892,7 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
 	public static Expression create_temp_access (LocalVariable local, DataType? target_type) {
 		Expression temp_access = new MemberAccess.simple (local.name, local.source_reference);
 
-		var target_owned = target_type == null || target_type.value_owned;
-		if (target_owned && local.variable_type.is_disposable ()) {
+		if (local.variable_type.is_disposable ()) {
 			temp_access = new ReferenceTransferExpression (temp_access, local.source_reference);
 			temp_access.target_type = target_type != null ? target_type.copy () : local.variable_type.copy ();
 			temp_access.target_type.value_owned = true;