From: Kees Monshouwer <mind04@monshouwer.org>
Date: Wed, 3 Aug 2022 14:36:28 +0000 (+0200)
Subject: auth: fix catalogDiff() coverity report
X-Git-Tag: rec-4.8.0-alpha1~70^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba2642a7f2c85246764c263679470aeb04577175;p=thirdparty%2Fpdns.git

auth: fix catalogDiff() coverity report
---

diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index fcb47be130..d8ccff1388 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -108,12 +108,12 @@ static bool catalogDiff(const DomainInfo& di, vector<CatalogInfo>& fromXFR, vect
       bool create{false};
       bool remove{false};
 
-      if ((xfr != fromXFR.end() && db == fromDB.end()) || *xfr < *db) { // create
+      if (xfr != fromXFR.end() && (db == fromDB.end() || *xfr < *db)) { // create
         ciCreate = *xfr;
         create = true;
         ++xfr;
       }
-      else if ((db != fromDB.end() && xfr == fromXFR.end()) || *db < *xfr) { // remove
+      else if (db != fromDB.end() && (xfr == fromXFR.end() || *db < *xfr)) { // remove
         ciRemove = *db;
         remove = true;
         ++db;