From: Rob van der Linde Date: Wed, 13 Dec 2023 01:03:14 +0000 (+1300) Subject: selftest: require named parameters for callers of connect_samdb() and connect_samdb_ex() X-Git-Tag: talloc-2.4.2~254 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba29bb54cada2e0d01a8b6f7a7587696d44fa1f9;p=thirdparty%2Fsamba.git selftest: require named parameters for callers of connect_samdb() and connect_samdb_ex() Signed-off-by: Rob van der Linde Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- diff --git a/python/samba/tests/__init__.py b/python/samba/tests/__init__.py index a9f45b437c2..318d1956619 100644 --- a/python/samba/tests/__init__.py +++ b/python/samba/tests/__init__.py @@ -580,7 +580,7 @@ class BlackboxTestCase(TestCaseInTempDir): return password -def connect_samdb(samdb_url, lp=None, session_info=None, credentials=None, +def connect_samdb(samdb_url, *, lp=None, session_info=None, credentials=None, flags=0, ldb_options=None, ldap_only=False, global_schema=True): """Create SamDB instance and connects to samdb_url database. @@ -625,7 +625,7 @@ def connect_samdb(samdb_url, lp=None, session_info=None, credentials=None, global_schema=global_schema) -def connect_samdb_ex(samdb_url, lp=None, session_info=None, credentials=None, +def connect_samdb_ex(samdb_url, *, lp=None, session_info=None, credentials=None, flags=0, ldb_options=None, ldap_only=False): """Connects to samdb_url database @@ -637,8 +637,9 @@ def connect_samdb_ex(samdb_url, lp=None, session_info=None, credentials=None, :param ldap_only: If set, only remote LDAP connection will be created. :return: (sam_db_connection, rootDse_record) tuple """ - sam_db = connect_samdb(samdb_url, lp, session_info, credentials, - flags, ldb_options, ldap_only) + sam_db = connect_samdb(samdb_url, lp=lp, session_info=session_info, + credentials=credentials, flags=flags, + ldb_options=ldb_options, ldap_only=ldap_only) # fetch RootDse res = sam_db.search(base="", expression="", scope=ldb.SCOPE_BASE, attrs=["*"])