From: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri, 31 Oct 2025 05:13:32 +0000 (-0400)
Subject: ksmbd_vfs_rename(): vfs_path_parent_lookup() accepts ERR_PTR() as name
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba33ac100d3feb1efb43b32e63cc0c6430936aa3;p=thirdparty%2Fkernel%2Flinux.git

ksmbd_vfs_rename(): vfs_path_parent_lookup() accepts ERR_PTR() as name

no need to check in the caller

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index a972261168407..30b65b667b96e 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -674,10 +674,6 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path,
 		return -ENOMEM;
 
 	to = getname_kernel(newname);
-	if (IS_ERR(to)) {
-		err = PTR_ERR(to);
-		goto revert_fsids;
-	}
 
 retry:
 	err = vfs_path_parent_lookup(to, lookup_flags | LOOKUP_BENEATH,
@@ -737,7 +733,6 @@ out2:
 	}
 out1:
 	putname(to);
-revert_fsids:
 	ksmbd_revert_fsids(work);
 	return err;
 }