From: Joel Rosdahl <joel@rosdahl.net>
Date: Sat, 2 Jan 2016 18:39:42 +0000 (+0100)
Subject: Add cppcheck Makefile target
X-Git-Tag: v3.2.5~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba39741ab39d1733776700b78c2e522009baca18;p=thirdparty%2Fccache.git

Add cppcheck Makefile target
---

diff --git a/Makefile.in b/Makefile.in
index 30beb2bfd..c6cdc0484 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -22,11 +22,32 @@ all_cflags = $(CFLAGS)
 all_cppflags = @DEFS@ -DSYSCONFDIR=$(sysconfdir) -I. -I$(srcdir) $(CPPFLAGS)
 extra_libs = @extra_libs@
 
-base_sources = \
-    ccache.c mdfour.c hash.c execute.c util.c args.c stats.c version.c \
-    cleanup.c snprintf.c unify.c manifest.c hashtable.c hashtable_itr.c \
-    murmurhashneutral2.c hashutil.c getopt_long.c exitfn.c lockfile.c \
-    counters.c language.c compopt.c conf.c
+non_3pp_sources = \
+    args.c \
+    ccache.c \
+    cleanup.c \
+    compopt.c \
+    conf.c \
+    counters.c \
+    execute.c \
+    exitfn.c \
+    hash.c \
+    hashutil.c \
+    language.c \
+    lockfile.c \
+    manifest.c \
+    mdfour.c \
+    stats.c \
+    unify.c \
+    util.c \
+    version.c
+3pp_sources = \
+    getopt_long.c \
+    hashtable.c \
+    hashtable_itr.c \
+    murmurhashneutral2.c \
+    snprintf.c
+base_sources = $(non_3pp_sources) $(3pp_sources)
 base_objs = $(base_sources:.c=.o)
 
 ccache_sources = main.c $(base_sources)
diff --git a/cppcheck-suppressions.txt b/cppcheck-suppressions.txt
new file mode 100644
index 000000000..98310e241
--- /dev/null
+++ b/cppcheck-suppressions.txt
@@ -0,0 +1,3 @@
+ConfigurationNotChecked
+missingIncludeSystem
+unusedFunction:test/test_*
diff --git a/dev.mk.in b/dev.mk.in
index def493a26..a6176f166 100644
--- a/dev.mk.in
+++ b/dev.mk.in
@@ -4,6 +4,8 @@ all_cflags += -Werror
 all_cppflags += -MD -MP -MF .deps/$(subst .._,,$(subst /,_,$<)).d
 
 ASCIIDOC = asciidoc
+CPPCHECK = cppcheck
+CPPCHECK_SUPPRESSIONS = cppcheck-suppressions.txt
 GPERF = gperf
 XSLTPROC = xsltproc
 MANPAGE_XSL = $(shell if [ -e /usr/local/etc/asciidoc/docbook-xsl/manpage.xsl ]; \
@@ -151,6 +153,12 @@ ccache.1: MANUAL.xml
 check-syntax:
 	$(CC) $(all_cppflags) -I. $(all_cflags) -S -o /dev/null $(CHK_SOURCES)
 
+.PHONY: cppcheck
+cppcheck:
+	$(CPPCHECK) --suppressions-list=$(CPPCHECK_SUPPRESSIONS) \
+	  --inline-suppr -q --enable=all \
+	  $(non_3pp_sources) main.c $(test_sources)
+
 .PHONY: uncrustify
 uncrustify:
 	uncrustify -c uncrustify.cfg --no-backup --replace $(filter-out $(uncrustify_exclude_files), $(base_sources)) $(test_sources)