From: Jason Ish <jason.ish@oisf.net>
Date: Wed, 27 Nov 2019 18:47:01 +0000 (-0600)
Subject: app-layer: validate TX detect flag callbacks
X-Git-Tag: suricata-5.0.1~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba3a2c31bf0544e531789d88b19cefd8f5c75dd9;p=thirdparty%2Fsuricata.git

app-layer: validate TX detect flag callbacks

Check that both are set or unset.
---

diff --git a/src/app-layer-parser.c b/src/app-layer-parser.c
index 4e526d493f..03f23dd1c7 100644
--- a/src/app-layer-parser.c
+++ b/src/app-layer-parser.c
@@ -1497,6 +1497,9 @@ static void ValidateParserProto(AppProto alproto, uint8_t ipproto)
     if (!(BOTH_SET_OR_BOTH_UNSET(ctx->GetTxDetectState, ctx->SetTxDetectState))) {
         goto bad;
     }
+    if (!(BOTH_SET_OR_BOTH_UNSET(ctx->GetTxDetectFlags, ctx->SetTxDetectFlags))) {
+        goto bad;
+    }
 
     return;
 bad: