From: Stefano Lattarini Date: Mon, 29 Apr 2013 14:39:47 +0000 (+0200) Subject: maintcheck: remove outdated whitelisting X-Git-Tag: v1.13.1d~18 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba7b59bf48ff262be97445ee4f4f94e85de4cb60;p=thirdparty%2Fautomake.git maintcheck: remove outdated whitelisting * syntax-checks.mk (sc_tests_overriding_macros_on_cmdline): Here. The test 'make-dryrun.sh' has been since long rewritten as the TAP test 'make-dryrun.tap', and no longer spuriously triggers this maintainer check. Signed-off-by: Stefano Lattarini --- diff --git a/syntax-checks.mk b/syntax-checks.mk index 375738be9..8f9d8b4c2 100644 --- a/syntax-checks.mk +++ b/syntax-checks.mk @@ -372,13 +372,7 @@ sc_tests_overriding_macros_on_cmdline: # The first s/// tries to account for usages like "$MAKE || st=$?". # 'DISTCHECK_CONFIGURE_FLAGS' and 'exp' are allowed to contain whitespace in # their definitions, hence the more complex last three substitutions below. -# Also, the 'make-dryrun.sh' is whitelisted, since there we need to -# override variables from the command line in order to cover the expected -# code paths. - @tests=`for t in $(xtests); do \ - case $$t in */make-dryrun.sh);; *) echo $$t;; esac; \ - done`; \ - if sed -e 's/ || .*//' -e 's/ && .*//' \ + @if sed -e 's/ || .*//' -e 's/ && .*//' \ -e 's/ DESTDIR=[^ ]*/ /' -e 's/ SHELL=[^ ]*/ /' \ -e 's/ V=[^ ]*/ /' -e 's/ DISABLE_HARD_ERRORS=[^ ]*/ /' \ -e "s/ DISTCHECK_CONFIGURE_FLAGS='[^']*'/ /" \ @@ -387,7 +381,7 @@ sc_tests_overriding_macros_on_cmdline: -e "s/ exp='[^']*'/ /" \ -e 's/ exp="[^"]*"/ /' \ -e 's/ exp=[^ ]/ /' \ - $$tests | grep '\$$MAKE .*='; then \ + $(xtests) | grep '\$$MAKE .*='; then \ echo 'Rewrite "$$MAKE foo=bar" as "foo=bar $$MAKE -e" in the above lines,' 1>&2; \ echo 'it is more portable.' 1>&2; \ exit 1; \