From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 13 May 2020 06:50:07 +0000 (+0200)
Subject: BUG/MINOR: http-rules: Mark http return rules as final
X-Git-Tag: v2.2-dev8~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba946bf23a3e08bb95a80947f0fc087d1dd5d7cd;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http-rules: Mark http return rules as final

For HTTP rules, this flag is only used to trigger a warning during HAProxy
startup when a final rule without ACL is not the last one. So this patch is
marked as a bug, but its impact is really limited.

No backport needed because http return rules were introduced in the 2.2.
---

diff --git a/src/http_act.c b/src/http_act.c
index e6e3df4f81..66cbe13082 100644
--- a/src/http_act.c
+++ b/src/http_act.c
@@ -2417,6 +2417,7 @@ static enum act_parse_ret parse_http_return(const char **args, int *orig_arg, st
 		free(obj);
 	}
 
+	rule->flags |= ACT_FLAG_FINAL;
 	rule->arg.http_return.status = status;
 	rule->arg.http_return.ctype = ctype;
 	rule->arg.http_return.hdrs = hdrs;