From: Vladimír Čunát Date: Mon, 5 Feb 2018 10:01:03 +0000 (+0100) Subject: version module: more understandable logging X-Git-Tag: v2.1.0~13^2~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bab47b995c7adf5f61b7312935e51fc49104fe59;p=thirdparty%2Fknot-resolver.git version module: more understandable logging Just loading the module without option was printing that it expected number of milliseconds, which could've been confusing. --- diff --git a/modules/version/version.lua.in b/modules/version/version.lua.in index 05cd92d2f..3585c359e 100644 --- a/modules/version/version.lua.in +++ b/modules/version/version.lua.in @@ -42,7 +42,7 @@ local function request (answer) if pkt:rcode() == kres.rcode.NOERROR then parse(pkt:rrsets(kres.section.ANSWER)[1]) else - print ('Request for version ended with rcode: ', pkt:rcode()) + log('[version] Request for version ended with rcode: ', pkt:rcode()) return end end @@ -52,12 +52,8 @@ local function callhome() end function M.config(period) - if period == nil then - print("Expected number of miliseconds. Using default version.config(1*day)") - return - end - if type(period) ~= "number" then - print("Expected number of miliseconds. Using default version.config(1*day)") + if not period or type(period) ~= "number" then + log("[version] Using default version.config(1*day)") return end M.period = period