From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Tue, 5 Jan 2016 11:02:19 +0000 (+0200)
Subject: Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()
X-Git-Tag: SQUID_4_0_4~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bac324a9168d4f980d7e8dea342b52988b08b3b3;p=thirdparty%2Fsquid.git

Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()
return non NULL before use the result

Detected by Coverity Scan. Issue 1346998
---

diff --git a/src/ssl/helper.cc b/src/ssl/helper.cc
index 852c2f522f..bd0bf6134b 100644
--- a/src/ssl/helper.cc
+++ b/src/ssl/helper.cc
@@ -259,6 +259,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
             (validationResponse = CertValidationHelper::HelperCache->get(crtdvdData->query.c_str()))) {
 
         CertValidationHelper::CbDialer *dialer = dynamic_cast<CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = *validationResponse;
         ScheduleCallHere(callback);
         SSL_free(crtdvdData->ssl);
@@ -270,6 +271,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
         Ssl::CertValidationResponse::Pointer resp = new Ssl::CertValidationResponse;;
         resp->resultCode = ::Helper::BrokenHelper;
         Ssl::CertValidationHelper::CbDialer *dialer = dynamic_cast<Ssl::CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = resp;
         ScheduleCallHere(callback);