From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 26 Jul 2021 23:12:34 +0000 (+1200)
Subject: tests/krb5: Fix callback_dict parameter
X-Git-Tag: ldb-2.5.0~955
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bad5f4ee5fdf64ca9d775233fec24975e0b510bf;p=thirdparty%2Fsamba.git

tests/krb5: Fix callback_dict parameter

Items contained in a default-created callback_dict should not be carried
over between unrelated calls to {as,tgs}_as_exchange_dict().

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index f39656d5e03..fc8e6990834 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -1486,7 +1486,7 @@ class RawKerberosTest(TestCaseInTempDir):
                          check_rep_fn=None,
                          check_padata_fn=None,
                          check_kdc_private_fn=None,
-                         callback_dict=dict(),
+                         callback_dict=None,
                          expected_error_mode=None,
                          client_as_etypes=None,
                          expected_salt=None):
@@ -1511,6 +1511,9 @@ class RawKerberosTest(TestCaseInTempDir):
             'client_as_etypes': client_as_etypes,
             'expected_salt': expected_salt,
         }
+        if callback_dict is None:
+            callback_dict = {}
+
         return kdc_exchange_dict
 
     def tgs_exchange_dict(self,
@@ -1524,7 +1527,7 @@ class RawKerberosTest(TestCaseInTempDir):
                           check_rep_fn=None,
                           check_padata_fn=None,
                           check_kdc_private_fn=None,
-                          callback_dict=dict(),
+                          callback_dict=None,
                           tgt=None,
                           authenticator_subkey=None,
                           body_checksum_type=None):
@@ -1549,6 +1552,9 @@ class RawKerberosTest(TestCaseInTempDir):
             'body_checksum_type': body_checksum_type,
             'authenticator_subkey': authenticator_subkey,
         }
+        if callback_dict is None:
+            callback_dict = {}
+
         return kdc_exchange_dict
 
     def generic_check_kdc_rep(self,